Re: LLVM breakage on seawasp

Hi,

On August 24, 2019 1:57:56 PM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Andres Freund <andres(at)anarazel(dot)de> writes:
>> On August 24, 2019 1:08:11 PM PDT, Thomas Munro
><thomas(dot)munro(at)gmail(dot)com> wrote:
>>> That's because they just moved to C++14 and replaced their own
>>> llvm::make_unique<> with std::make_unique<>:
>>>
>https://github.com/llvm-mirror/llvm/commit/114087caa6f95b526861c3af94b3093d9444c57b
>>> Perhaps we'll need some macrology to select between llvm and std
>>> versions? I am guessing we can't decree that PostgreSQL's minimum
>C++
>>> level is C++14 and simply change it to std::make_unique.
>
>So we're depending on APIs that upstream doesn't think are stable?

Seawasp iirc builds against the development branch of llvm, which explains why we see failures there. Does that address what you are concerned about? If not, could you expand?

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.