| From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
|---|---|
| To: | "Stephen J(dot) Butler" <stephen(dot)butler(at)gmail(dot)com> |
| Cc: | Martijn van Oosterhout <kleptog(at)svana(dot)org>, Alex Hunsaker <badalex(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexey Klyukin <alexk(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: arrays as pl/perl input arguments [PATCH] |
| Date: | 2011-01-14 00:22:31 |
| Message-ID: | E1D41132-12DA-4012-95A0-FE8A983789A7@kineticode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Jan 13, 2011, at 4:15 PM, Stephen J. Butler wrote:
> Suppose one of these compatibility objects is passed into legacy code
> as $_[0]. The problem is that 'ref $_[0]' will return 'Pg::ArrayArg'
> instead of what it used to, '' (empty string). Other than that, I
> think it performs as people would expect.
Well, frankly, since up to this patch you *never* got an ARRAY reference argument, who would be calling `ref` on it anyway?
> You could even change 'as_s' to generate the string on the fly as
> requested instead of generating both representations at instantiation.
Yep.
Best,
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-14 00:25:09 | Re: auto-sizing wal_buffers |
| Previous Message | Kevin Grittner | 2011-01-14 00:21:43 | Re: SSI patch version 8 |