Re: Automatic transactions in psql

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Automatic transactions in psql
Date: 2002-02-22 17:12:39
Message-ID: E16eJ6e-0000xF-00@maynard.mail.mindspring.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> I believe Fernando Nasser at Red Hat is currently working on backend
> changes to do this properly; so I recommend we not apply the psql hack

Sounds good to me. If he is not, I'll volunteer if someone will point
me in the right direction.

> The notion of customizing the psql prompt based on
> in-an-xact-block-or-not seems cool; but I do not see how to do it
> reliably without a protocol change, and it's not worth that.

<devil's advocate>
Surely it's being done at least as reliably as the hack in large_obj.c? :)
</da>
I don't think it's that unreliable myself: as long as the backend outputs
the standard confirmation message (e.g. "BEGIN"), we should always be
able to keep track. And a dropped connection means we switch to "not in a
transaction"

-----BEGIN PGP SIGNATURE-----
Comment: http://www.turnstep.com/pgp.html

iD8DBQE8dnuTvJuQZxSWSsgRAnnFAJ9vz2o1bYiDB1jfnBE2cWohDAw0IwCglMX5
LUgc2CcQAsdueSpFWH+mwxE=
=e0qZ
-----END PGP SIGNATURE-----

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-02-22 17:55:50 Re: Fix command completion for CREATE TABEL ... AS
Previous Message Tom Lane 2002-02-22 16:17:25 Re: Automatic transactions in psql