Re: Thread-safe stringToNode() / pg_strtok()

Hi Matthias,

Thanks for v2. I think the ExtensibleNode path still needs an update.
_readExtensibleNode() receives ReadNodeContext *ctx, but still calls:
methods->nodeRead(local_node);

Since pg_strtok(), readBitmapset(), and the other reader helpers now
require ctx, an extension's nodeRead callback has no way to read its
private fields. External extensions such as Apache AGE, DocumentDB and
AQO implement ExtensibleNode nodeRead callbacks using pg_strtok() and
related reader helpers.

Should ExtensibleNodeMethods.nodeRead also receive ReadNodeContext, for
example:
void (*nodeRead)(ReadNodeContext *ctx, ExtensibleNode *node);
and be called as:
methods->nodeRead(ctx, local_node);

Best Regards,
Yuhang Qiu.