Re: [PATCH] Report malformed integer aggregate states as array errors

From: "Strydom, Matthys" <strydom(at)amazon(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Burd, Greg" <gregburd(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Report malformed integer aggregate states as array errors
Date: 2026-11-12 17:17:00
Message-ID: DS2PR18MB927569D61E3C3723E54C9EE386C9702@DS2PR18MB927569.namprd18.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> It's not reasonable for people to call these functions directly ---
> indeed there's been discussion about making that impossible, and then
> stripping out some of these error checks.

Thanks for the quick response. That makes sense. Since these functions
are callable today, I thought returning a more specific error would be
a small improvement, till the functions are made not callable.

I would be interested in helping make these aggregate support functions
impossible to call directly. Could you point me to the earlier
discussion, or to the preferred direction if one has emerged?

If there is a reasonably self-contained part of that work suitable for
a first PostgreSQL patch, I would be happy to investigate it.

Kind regards,
Matthys

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-11-12 17:39:42 Re: A gap in preventing bogus parameterizations in a798660ebe3
Previous Message Bharath Rupireddy 2026-11-12 17:04:35 Re: Teach pg_upgrade to deal with invalid databases