Re: Python/pytest test framework take two

From: "Jelte Fennema-Nio" <me(at)jeltef(dot)nl>
To: "Nikolay Samokhvalov" <nik(at)postgres(dot)ai>
Cc: "pgsql-hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Python/pytest test framework take two
Date: 2026-11-04 21:07:14
Message-ID: DMMQEFKMPQ5S.144FVVXW8SPSI@jeltef.nl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 29 Oct 2026 at 20:04, Nikolay Samokhvalov <nik(at)postgres(dot)ai> wrote:
> 1. result(timeout=...) and exception(timeout=...) mark a future consumed
> before waiting. A caught timeout can therefore allow connection reuse
> while the query still runs. The first patch fixes this: eight baseline
> failures become passes (20/20 total).

Hmm, yeah that's a bug (a small one though). I solved it differently
than your suggestion. (see attached v3)

> 2. The bulk pg_visibility conversion (8a8f008f7596) misses
> close_portal("") after begin / select txid_current(), retaining a snapshot
> that psql releases. The second patch adds two passing comparison tests
> for this documented behavior.

This pg_visibility conversion wasn't part of the patchset I submitted on
the list. That referenced commit is part of a branch on my own postgres
fork that I didn't submit for review because it was not ready. So I'm
not adding this one.

Attachment Content-Type Size
v3-0001-ci-show-more-than-100-lines-of-a-failing-test-s-l.patch text/x-patch 1.6 KB
v3-0002-meson-Deduplicate-test-timeout-into-a-variable.patch text/x-patch 2.5 KB
v3-0003-ci-temporarily-install-a-32-bit-Python-in-the-32-.patch text/x-patch 3.0 KB
v3-0004-Add-support-for-pytest-test-suites.patch text/x-patch 34.6 KB
v3-0005-Add-pytest-infrastructure-to-interact-with-Postgr.patch text/x-patch 176.2 KB
v3-0006-POC-amcheck-port-TAP-test-001_verify_heapam-to-py.patch text/x-patch 17.4 KB
v3-0007-POC-test_json_parser-port-TAP-test-002_inline-to-.patch text/x-patch 13.7 KB
v3-0008-POC-recovery-port-TAP-test-049_wait_for_lsn-to-py.patch text/x-patch 99.3 KB
v3-0009-POC-test_aio-port-TAP-test-001_aio-to-pytest.patch text/x-patch 106.4 KB
v3-0010-POC-recovery-port-TAP-test-029_stats_restart-to-p.patch text/x-patch 22.9 KB
v3-0011-POC-recovery-port-TAP-test-031_recovery_conflict-.patch text/x-patch 25.4 KB
v3-0012-POC-subscription-port-TAP-test-031_column_list-to.patch text/x-patch 83.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirk Wolak 2026-11-04 21:07:39 Re: PG19 regression in ecd9288624a: JSON_ARRAY() indexes that go stale
Previous Message Lukas Fittl 2026-11-04 20:50:33 Re: Fix cumulative WAL statistics double-counting from parallel workers