Re: [PATCH] Print error when libpq-refs-stamp fails

From: Rachel Heaton <rachelmheaton(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "a(dot)voloshin(at)postgrespro(dot)ru" <a(dot)voloshin(at)postgrespro(dot)ru>
Subject: Re: [PATCH] Print error when libpq-refs-stamp fails
Date: 2021-10-05 00:09:29
Message-ID: DM6PR17MB31944275D8ACD1C95EE8CE71AFAF9@DM6PR17MB3194.namprd17.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks to you both!

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
Date: Monday, October 4, 2021 at 11:36 AM
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: Rachel Heaton <rachelmheaton(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org <pgsql-hackers(at)lists(dot)postgresql(dot)org>, a(dot)voloshin(at)postgrespro(dot)ru <a(dot)voloshin(at)postgrespro(dot)ru>
Subject: Re: [PATCH] Print error when libpq-refs-stamp fails
> On 4 Oct 2021, at 19:21, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 4 Oct 2021, at 19:02, Jacob Champion <pchampion(at)vmware(dot)com> wrote:
>>
>> On Mon, 2021-10-04 at 23:40 +0700, Anton Voloshin wrote:
>>>
>>> Could you please confirm that the change from -A to -a in nm arguments
>>> in this patch is intentional?
>>
>> That was not intended by us, thank you for the catch! A stray
>> lowercasing in vim, perhaps.
>
> Hmm, I will take care of this shortly.

Right, so I missed this in reviewing and testing, and I know why the latter
didn't catch it. nm -A and -a outputs the same thing *for this input* on my
Debian and macOS boxes, with the small difference that -A prefixes the line
with the name of the input file. -a also include debugger symbols, but for
this usage it didn't alter the results. I will go ahead and fix this, thanks
for catching it!

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2021-10-05 00:22:04 Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers)
Previous Message Peter Geoghegan 2021-10-04 23:45:14 Re: BUG #17212: pg_amcheck fails on checking temporary relations