| From: | "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | "Heikki Linnakangas" <hlinnaka(at)iki(dot)fi> |
| Cc: | "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org>, "Jacob Champion" <jacob(dot)champion(at)enterprisedb(dot)com> |
| Subject: | Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore |
| Date: | 2026-09-02 18:14:21 |
| Message-ID: | DL519QREJ4P1.2Z9UAEYVCTNQ2@jeltef.nl |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue Jul 7, 2026 at 4:52 PM CEST, Heikki Linnakangas wrote:
> a) switch to pselect() where available, fall back to select() with
> timeout. We don't currently use pselect() anywhere, so this needs a new
> configure check.
I've rebased again, and I realized I didn't call this out, but I went
for the pselect approach.
It would be nice to at least commit the first patch, since:
1. it's a nice cleanup
2. Michael agreed that it's fine now
3. it's the main thing that's requiring me to rebase this series again
and again.
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-psql-Replace-cancel_pressed-with-CancelRequested.patch | text/x-patch | 21.9 KB |
| v12-0002-fe_utils-Simplify-cancel-logic-in-wait_on_slots.patch | text/x-patch | 7.5 KB |
| v12-0003-Move-Windows-pthread-compatibility-functions-to-.patch | text/x-patch | 2.8 KB |
| v12-0004-Don-t-use-deprecated-and-insecure-PQcancel-psql-.patch | text/x-patch | 42.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-09-02 18:19:21 | Re: REPACK (CONCURRENTLY) can crash a logical decoding session |
| Previous Message | Andrei Lepikhov | 2026-09-02 18:12:49 | Re: hashjoins vs. Bloom filters (yet again) |