| From: | "Tristan Partin" <tristan(at)partin(dot)io> |
|---|---|
| To: | Miłosz Bieniek <bieniek(dot)milosz(at)proton(dot)me> |
| Cc: | "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Support UUIDv6 in uuid_extract_timestamp() |
| Date: | 2026-07-28 17:08:09 |
| Message-ID: | DKADBFT0XXAS.2AI4M6NB4KL70@partin.io |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun Jul 26, 2026 at 4:38 PM UTC, Miłosz Bieniek wrote:
> Hi,
>
> On Sunday, 26 July 2026 at 18:05, Tristan Partin <tristan(at)partin(dot)io> wrote:
>
>> UUIDv6 is the same as UUIDv1 with some fields reordered. We already
>> supported UUIDv1, so let's add support for UUIDv6. Previously, calls to
>> uuid_extract_timestamp() would return NULL for UUIDv6 values.
>
> Makes sense, this would be the last missing piece in uuid_extract_timestamp(). The code itself looks good.
>
>> Patch 2 only adds comments. I think the bit manipulation is worthy of
>> comments, but others may disagree.
>
> I think it's a good idea. Now it's much easier to understand what's going on with these wild manipulations.
Thanks for the review.
--
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-07-28 17:45:39 | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |
| Previous Message | Ayush Tiwari | 2026-07-28 17:06:33 | Re: [PATCH] SAOP nullability analysis below NOT/BooleanTest |