| From: | "Tristan Partin" <tristan(at)partin(dot)io> |
|---|---|
| To: | "Bharath Rupireddy" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add MIN/MAX aggregate support for uuid |
| Date: | 2026-06-24 21:26:10 |
| Message-ID: | DJHLIGZ9MM7N.2BD5ZB4DMWQCE@partin.io |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed Jun 24, 2026 at 7:47 PM UTC, Bharath Rupireddy wrote:
> Hi,
>
> On Wed, Jun 24, 2026 at 12:13 PM Tristan Partin <tristan(at)partin(dot)io> wrote:
>>
>> Any opinions on what the descriptions should be? Here are the equivalent
>> functions for OID:
>>
>> { oid => '1965', descr => 'larger of two',
>> proname => 'oidlarger', prorettype => 'oid', proargtypes => 'oid oid',
>> prosrc => 'oidlarger' },
>> { oid => '1966', descr => 'smaller of two',
>> proname => 'oidsmaller', prorettype => 'oid', proargtypes => 'oid oid',
>> prosrc => 'oidsmaller' },
>
> What you have in the v2 patch looks fine to me. "minimum/maximum value
> of all UUID input values" gives it a bit of an "aggregate flavor" as
> well - as in, when used in select min(uuid_col) from foo, it returns
> the minimum value of all UUID input values.
I ended up just using a similar string as oidlarger and bytea_larger.
Although, I added the word "the" to make the descriptions a little more
readable than their counterparts.
"larger of the two" and "smaller of the two"
--
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-MIN-MAX-aggregate-support-for-uuid.patch | text/x-patch | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-06-24 21:32:08 | Re: Add MIN/MAX aggregate support for uuid |
| Previous Message | Zsolt Parragi | 2026-06-24 21:19:33 | Re: glob support in extension_control_path/dynamic_library_path? |