| From: | "Matheus Alcantara" <matheusssilv97(at)gmail(dot)com> |
|---|---|
| To: | "Ayush Tiwari" <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | "Rafia Sabih" <rafia(dot)pghackers(at)gmail(dot)com>, <798604270(at)qq(dot)com>, <pgsql-bugs(at)lists(dot)postgresql(dot)org>, "Etsuro Fujita" <etsuro(dot)fujita(at)gmail(dot)com>, "Amit Langote" <amitlan(at)postgresql(dot)org> |
| Subject: | Re: BUG #19484: Segmentation fault triggered by FDW |
| Date: | 2026-06-10 11:08:56 |
| Message-ID: | DJ5BM93JVJ7C.MQC43GITCBOY@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed Jun 10, 2026 at 2:15 AM -03, Ayush Tiwari wrote:
>> One minor naming observation: the new fdwPrivLists field in
>> ModifyTableState doesn't follow the mt_ prefix convention used by the
>> other re-indexed lists (mt_updateColnosLists, mt_mergeActionLists,
>> mt_mergeJoinConditions). Should we rename it to mt_fdwPrivLists for
>> consistency?
>>
>
> I think yes, it makes sense to rename it.
>
Attached v2 renamed, thanks.
(Also CC Amit on this since he committed cbc127917e0 which I believe
that is when the issue started)
--
Matheus Alcantara
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Re-index-ModifyTable-FDW-arrays-when-pruning-resu.patch | text/plain | 10.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-06-10 13:04:48 | Re: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change |
| Previous Message | Marko Grujic | 2026-06-10 10:50:39 | Re: BUG #19516: Mixup of OLD/NEW with RETURNING when parenthesized |