Re: Make copyObject work in C++

From: "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>
To: "Peter Eisentraut" <peter(at)eisentraut(dot)org>
Cc: "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Thomas Munro" <thomas(dot)munro(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>
Subject: Re: Make copyObject work in C++
Date: 2026-03-29 22:53:48
Message-ID: DHFMW63NP35Z.3RRS8PIYV508K@jeltef.nl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 27 Mar 2026 at 12:23, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> Here is another tidied up patch set for this. I didn't go quite as far
> as enabling C++20 by default in meson.build, this would just take more
> time to work out and test all the different combinations, but I added
> the flag to the Cirrus CI task, since there we know what compiler we have.

I think 0001 and 0002 are good.

0003 seems awkward though. Attached is an approach that I think is
better: It actually checks for the required featureset and adds the
necessary flags to the compiler.

I also added a small patch in 0004 to align configure and meson
behaviour when no sufficiently modern compiler is found.

Attachment Content-Type Size
v12-0001-meson-Make-room-for-C-only-warning-flags-for-MSV.patch text/x-patch 2.3 KB
v12-0002-Disable-some-C-warnings-in-MSVC.patch text/x-patch 900 bytes
v12-0003-Add-support-for-C-extensions-with-MSVC.patch text/x-patch 5.7 KB
v12-0004-meson-Consider-an-insufficient-C-compiler-a-warn.patch text/x-patch 1005 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message SATYANARAYANA NARLAPURAM 2026-03-29 23:51:27 Re: Add max_wal_replay_size connection parameter to libpq
Previous Message Tom Lane 2026-03-29 22:23:31 Re: pg_waldump: support decoding of WAL inside tarfile