Re: Safer hash table initialization macro

From: "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>
To: "Bertrand Drouvot" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: "Thomas Munro" <thomas(dot)munro(at)gmail(dot)com>, <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Safer hash table initialization macro
Date: 2026-01-26 10:05:49
Message-ID: DFYFQDUFZ38Q.1LEJWN1P20X8Q@jeltef.nl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon Jan 26, 2026 at 9:41 AM CET, Bertrand Drouvot wrote:
> Hi,
>
> On Mon, Jan 26, 2026 at 12:38:15AM +0100, Jelte Fennema-Nio wrote:
>> On Wed Jan 14, 2026 at 9:46 AM CET, Jelte Fennema-Nio wrote:
>> > Changed wording and changed to NOTE.
>>
>> Attached is v7 which is rebased and changed the hash_create calls
>> introduced by 282b1cde9de.
>
> Thanks!
>
> The changes make sense to me.
>
> Just a pgindent nit, in 0003:

Fixed

> Also, I can see (I think it's coming from 0004):

Are you sure you applied the latest one, I had seen that in CI and fixed
it in v7. Should definitely be fixed now at least.

Attachment Content-Type Size
v8-0001-Add-hash_make-macros.patch text/x-patch 15.2 KB
v8-0002-Add-foreach_hash-macro.patch text/x-patch 3.9 KB
v8-0003-Use-hash_make-macros-throughout-the-codebase.patch text/x-patch 97.4 KB
v8-0004-Use-foreach_hash-macro-throughout-the-codebase.patch text/x-patch 71.9 KB
v8-0005-Inline-functions-that-have-now-become-trivial.patch text/x-patch 5.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2026-01-26 10:13:57 meson: Make test output much more useful on failure (both in CI and locally)
Previous Message Fujii Masao 2026-01-26 09:52:58 Re: Is abort() still needed in WalSndShutdown()?