Re: RFC: adding pytest as a supported test framework

On Mon Jan 19, 2026 at 12:34 PM CET, Aleksander Alekseev wrote:
> Hi,
>
>> v10 attached to resolve merge conflicts.
>
> I tested and reviewed patches 0001 .. 0003 on Linux x64. All in all
> the code is in a pretty good shape except for several TODOs:
>
> ```
> # TODO: proper quoting
> v = v.replace("\\", "\\\\")
> v = v.replace("'", "\\'")
> v = "'{}'".format(v)
> ```

Thanks for the review. Attached is v11. I addressed this TODO by
implementing the full quoting logic.

> and:
>
> ```
> # TODO: rather than using callback(), consider explicitly signaling
> # the fn() implementation to stop early if we get an exception.
> # Otherwise we'll hang until the end of the timeout.
> self._thread = threading.Thread(target=_bg)
> self.callback(self._join)
> ```

I moved the whole local_server fixture and the test that it adds into
patch 0004, i.e. the first WIP patch by Jacob. I don't think this
functionality (nor the test it added) needs to be part of the initial
merge.

> ```
> # XXX interacts poorly with testwrap's boilerplate diagnostics
> # self.print("TAP version 13")
> ```

Removed this and changed the comment on the TAP class to specify that
we're implementing TAP 12 instead (which requires no version line).
TAP 13 doesn't seem to contain features that we currently need.

> I haven't looked at 0004 and 0005.

Makes sense. I mostly kept those patches as part of the patchset to make
sure I did not break Jacob's usecase with all my changes to the test
suite. They were more meant as: "I did not touch these patches, nor are
they ready to merge, but it's possible to do stuff like this too".