| From: | "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | "Anthonin Bonnefoy" <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, "Japin Li" <japinli(at)hotmail(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Akshat Jaimini" <destrex271(at)gmail(dot)com>, <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Always show correct error message for statement timeouts, fixes random buildfarm failures |
| Date: | 2026-01-14 11:25:14 |
| Message-ID: | DFO9WNI3OW67.6FITRHIIEO8J@jeltef.nl |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed Jan 14, 2026 at 11:42 AM CET, Anthonin Bonnefoy wrote:
> I've encountered a related issue which is fixed by Jelte's patch.
Great that it fixes that too.
> The comment feels a bit misleading.
Updated the comment now (I had copied it verbatim from its original
location, but I agree it didn't describe the new behaviour clearly).
> Is it still possible to have both the statement timeout active and
> fired? You added the change to enable_statement_timeout to avoid
> restarting it when it was already triggered, so I would expect an
> active timeout to not have the indicator flag set. I guess there's the
> possible race where the timeout is triggered between
> get_timeout_active and disable_timeout.
Updated that comment to make it clear that it's indeed there for that rare
race condition.
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Do-not-reset-statement_timeout-indicator-outside-.patch | text/x-patch | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-01-14 11:31:04 | RE: Simplify code building the LR conflict messages |
| Previous Message | Amit Kapila | 2026-01-14 11:20:53 | Re: [BUG] [PATCH] Allow physical replication slots to recover from archive after invalidation |