Re: Allow auto_explain to log to NOTICE

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Dunstan <tom(at)tomd(dot)cc>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, jdealmeidapereira(at)pivotal(dot)io
Subject: Re: Allow auto_explain to log to NOTICE
Date: 2019-01-31 13:55:53
Message-ID: DE7132A9-64BC-4544-8898-30BE504E5A63@yesql.se
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On 5 Jan 2019, at 01:04, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jan 04, 2019 at 02:45:55PM +0100, Daniel Gustafsson wrote:
>> (Michael: sorry for not having responded to your comments on the patch, $life
>> has had little time over for hacking lately)
>
> No worries, I understand.
>
>> There is that. We might not be excited about writing tests for this
>> contrib module but someone else might want to use this for testing
>> their application in a similar manner to how pg_regress tests?
>
> If we don't introduce it, there is no way to know. Still if somebody
> needs to create regression tests they could just use EXPLAIN for the
> same purpose. However, the option still seems useful to me to get out
> plans with the most generic output, so I support the idea. If others
> don't feel so, I am fine to give up as well.

This didn’t attract any other interested parties, and I don’t feel the added
complexity is worth a continued discussion, so I’m closing this patch. Thanks
for the review.

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-01-31 13:56:08 Re: Add client connection check during the execution of the query
Previous Message Pavel Stehule 2019-01-31 13:54:49 Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)