Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)
Date: 2019-01-31 13:54:49
Message-ID: CAFj8pRCHRhG6AWnU5VKHsvA_L3DjQOnUvT=eRdSPz0qfA6ig4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

čt 31. 1. 2019 v 14:44 odesílatel Andres Freund <andres(at)anarazel(dot)de> napsal:

> Hi,
>
> On 2018-09-18 11:33:38 -0400, Tom Lane wrote:
> > Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > > [ xml-xpath-default-ns-7.patch ]
> >
> > At Andrew's prompting, I took a look over this patch. I don't know much
> > of anything about XML, so I have no idea as to standards compliance here,
> > but I do have some comments:
> >
> > * I'm fairly uncomfortable with the idea that we're going to maintain
> > our own XPath parser. That seems like a recipe for lots of future
> > work ... and the code is far too underdocumented for anyone to actually
> > maintain it. (Case in point: _transformXPath's arguments are not
> > documented at all, and in fact there's hardly a word about what it's
> > even supposed to *do*.)
>
> We were looking at this patch at the pgday developer meeting: Our
> impression is that this patch should be rejected. If really desired, the
> best approach seems to be actually implement this in libxml, and then go
> from there.
>

Unfortunately, the development of libxml2 is frozen.

I have to accept it.

Regards

Pavel

> Greetings,
>
> Andres Freund
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2019-01-31 13:55:53 Re: Allow auto_explain to log to NOTICE
Previous Message John Naylor 2019-01-31 13:53:44 Re: WIP: Avoid creation of the free space map for small tables