Re: meson's in-tree libpq header search order vs -Dextra_include_dirs

From: "Tristan Partin" <tristan(at)partin(dot)io>
To: "Thomas Munro" <thomas(dot)munro(at)gmail(dot)com>
Cc: "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: meson's in-tree libpq header search order vs -Dextra_include_dirs
Date: 2025-11-04 06:25:05
Message-ID: DDZP25P4VZ48.3LWMZBGA1K9RH@partin.io
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

After my analysis in the other subthread, patch 1 looks ready to be
committed. Patch 2 looks good to go, but maybe you should split the "set
-e" changes into a separate commit. Not sure how much I like patch
3 since it hardcodes $libdir as "lib" for the purposes of finding the
header, but it's also kind of a last resort thing, so ¯\_(ツ)_/¯. Maybe
it's best if the meson build just copies whatever the autotools build
does?

--
Tristan Partin
Databricks (https://databricks.com)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sadhuprasad Patro 2025-11-04 06:50:03 Re: Improved TAP tests by replacing sub-optimal uses of ok() with better Test::More functions
Previous Message shveta malik 2025-11-04 06:23:34 Re: Improve pg_sync_replication_slots() to wait for primary to advance