Re: Proposal: adding --enable-shadows-warning

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: adding --enable-shadows-warning
Date: 2025-11-28 09:39:23
Message-ID: DD9CFD73-F5B6-4225-A506-B27185CE5BC0@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 28, 2025, at 17:20, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 28 Nov 2025, at 10:02, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>> To make hacker’s life easier, it would make sense to always enable “-Wshadow”, however, that may have a risk of breaking some compilers. So thinking over, I just fell adding an opt-in “—enable-shadows-warnings” could be a solution.
>
> I'm not sure that adding buildsystem flags for compiler behaviour is the right
> direction, isn't the environment variables like CFLAGS already covering this?
>

Like I explained in my first email, using PROFILE can append extra options to CFLAGS, I am always use this method to append ‘-O0’ to CFLAGS. However, this way is easy to missing the extra option to add. As CommitFest CI always enable -Wshadows, we should allow developers to always enable the option in local.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2025-11-28 09:51:16 Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements
Previous Message vignesh C 2025-11-28 09:33:34 Re: Fix a recent "shadow warning" in subscriptioncmds.c