| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Sehrope Sarkuni <sehrope(at)jackdb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, "david(at)fetter(dot)org" <david(at)fetter(dot)org> |
| Subject: | Re: Add jsonlog log_destination for JSON server logs |
| Date: | 2021-10-07 06:00:08 |
| Message-ID: | DD8AD4CE-63B7-44BE-A3D2-14A4E4B19C26@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/5/21, 12:22 AM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> - 0001 does some refactoring of the file rotation in syslogger.c,
> that's the same patch as previously posted.
My compiler is unhappy with 5c6e33f:
syslogger.c: In function ‘logfile_rotate_dest’:
syslogger.c:1302:11: warning: ‘logFileExt’ may be used uninitialized in this function [-Wmaybe-uninitialized]
filename = logfile_getname(fntime, logFileExt);
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The attached patch seems to fix it.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| fix_warning.patch | application/octet-stream | 474 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-10-07 06:24:53 | Re: strange case of "if ((a & b))" |
| Previous Message | Amit Kapila | 2021-10-07 05:56:14 | Re: Parallel vacuum workers prevent the oldest xmin from advancing |