From: | "Kekalainen, Otto" <ottoke(at)amazon(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Fix various spelling errors |
Date: | 2022-03-15 16:40:42 |
Message-ID: | DD5765E1-F48A-4E04-A16B-4CFED33581EB@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2022-03-14, 19:47, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> It is useful to group that together. I have gathered everything that
> looked like a typo or a grammar mistake, and applied the fixes.
That was quick, thanks!
Please next time use `git am` to import the patch so that author and other
commit metadata is kept, or if you apply patches manually then commit with `git
--author` so that original author will be correct in the commit and your name
will be only in the committer field.
This was just a spelling fix so I don't care, but for other people doing more
significant contributions, getting the git authorship and having a PostgreSQL
contribution show up on their Gihub (or Gitlab profile, or in other tools that
read git commits) can be important and maybe the only reward/credit for those
doing open source on their free time.
Again, personally I don't care and I don't need Github credits for this, just
stating as general advice for a better contribution process in the future.
- Otto
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-03-15 16:44:49 | Re: Corruption during WAL replay |
Previous Message | Ashutosh Sharma | 2022-03-15 16:30:33 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |