| From: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Renaming PG_GETARG functions (was Re: PG_GETARG_GISTENTRY?) |
| Date: | 2017-09-12 22:16:01 |
| Message-ID: | DC665FAC-B869-4F0D-8737-B1ED1D5582F6@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 12, 2017, at 1:07 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> [ changing subject line to possibly draw more attention ]
>
> Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
>>> On Apr 5, 2017, at 9:23 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> In short, if you are supposed to write
>>> FOO *val = PG_GETARG_FOO(n);
>>> then the macro designer blew it, because the name implies that it
>>> returns FOO, not pointer to FOO. This should be
>>> FOO *val = PG_GETARG_FOO_P(n);
>
>> I have written a patch to fix these macro definitions across src/ and
>> contrib/.
>
Thanks, Tom, for reviewing my patch.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2017-09-12 22:39:59 | Re: Patches that don't apply or don't compile: 2017-09-12 |
| Previous Message | Thomas Munro | 2017-09-12 22:08:38 | Re: Automatic testing of patches in commit fest |