Re: "openssl" should not be optional

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: "openssl" should not be optional
Date: 2025-09-24 13:57:46
Message-ID: DB9931FA-8A28-4958-BC00-3667F527FCFC@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Sep 2025, at 13:51, Christoph Berg <myon(at)debian(dot)org> wrote:

>> Do you feel like expanding your patch or should I?
>
> TBH I know very little about how TAP interfaces with the build system,
> so that's better with you.

Looking at this I was reminded that we already handle this by using a fallback
and the test worked all along. The message for this was quite poorly worded
though, and used a warning instead of a note. The attached will try to detect
openssl being missing before trying to run it, and will skip the warning
message if the fallback is used (which really isn't a warning in the first
place).

The ERROR in 003_sslinfo is intentional, we are testing that processing fails
by passing an invalid value.

--
Daniel Gustafsson

Attachment Content-Type Size
v2-0001-Avoid-warnings-in-ssl-tests-when-openssl-isn-t-av.patch application/octet-stream 2.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arseniy Mukhin 2025-09-24 13:59:07 Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
Previous Message Timur Magomedov 2025-09-24 13:47:37 Re: [WIP]Vertical Clustered Index (columnar store extension) - take2