| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove unnecessary static specifier |
| Date: | 2025-02-06 15:39:51 |
| Message-ID: | DB31293E-7DA8-4C2C-91B3-584D399FD2D1@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Feb 2025, at 02:51, Japin Li <japinli(at)hotmail(dot)com> wrote:
>
> On Wed, 05 Feb 2025 at 18:17, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> On 5 Feb 2025, at 17:05, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>>> While we're at it, could we make the adjacent "magic" string be
>>> "static const char *magic"? (Probably needs a couple more
>>> "const" modifiers at use sites, too.)
>>
>> Good point, from the link referenced it's clear that FreeBSD has made that
>> change as well. I'll fix that at the same time.
>
> Oh, I didn't notice this. +1.
Committed, thanks!
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-02-06 15:42:43 | Re: Trigger more frequent autovacuums of heavy insert tables |
| Previous Message | Alexander Borisov | 2025-02-06 15:39:08 | Re: Optimization for lower(), upper(), casefold() functions. |