Re: pg_waldump: support decoding of WAL inside tarfile

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Masao Fujii <masao(dot)fujii(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
Date: 2026-03-29 01:59:21
Message-ID: D9BBAD84-A69C-48BD-9C79-341EA04D8E13@dunslane.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mar 28, 2026, at 7:34 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>>> On Sun, Mar 29, 2026 at 11:37 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> It looks like to make this test stable on modern FreeBSD,
>>> we need to see if tar accepts --no-read-sparse and use that
>>> switch if so.
>
>> Yeah. Here's my attempt at perl.
>
> Andrew might have some stylistic suggestions, but this looks
> plausible to me.

Looks basically ok to me, although I wouldn’t make the variable name all caps.

Cheers

Andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2026-03-29 02:01:24 Re: pg_waldump: support decoding of WAL inside tarfile
Previous Message Junwang Zhao 2026-03-29 01:40:22 Re: SQL Property Graph Queries (SQL/PGQ)