Re: a small proposal for avoiding foot-shooting

From: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
To: "Tom Lane *EXTERN*" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrew Gierth" <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: a small proposal for avoiding foot-shooting
Date: 2008-12-22 08:44:23
Message-ID: D960CB61B694CF459DCFB4B0128514C202E27B0D@exadv11.host.magwien.gv.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
>> I propose that this behaviour be changed such that 'terse' is ignored
>> for all log messages of FATAL or PANIC severity.
>> [ on the strength of a single example ]
>
[...]
>
> It seems like it might be better to rephrase error messages to ensure
> that anything really critical is mentioned in the primary message.
> In this case, perhaps instead of
> errmsg("could not locate required checkpoint record")
> we could have it print
> errmsg("could not locate checkpoint record specified in file \"%s/backup_label\".", DataDir)
> assuming we did actually get the location from there.
>
> Anyway, you've omitted a lot of details that would be necessary
> to judge exactly what was misleading about what the DBA saw.

I *guess* it is the problem addressed by

http://archives.postgresql.org/pgsql-committers/2008-04/msg00275.php
and
http://archives.postgresql.org/pgsql-committers/2008-04/msg00358.php

Yours,
Laurenz Albe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2008-12-22 12:21:01 Re: a small proposal for avoiding foot-shooting
Previous Message Tatsuo Ishii 2008-12-22 08:14:09 Lock conflict behavior?