| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: On login trigger: take three |
| Date: | 2022-03-15 20:52:43 |
| Message-ID: | D919E528-FA84-4094-9468-E53DB27CF4BB@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 14 Mar 2022, at 17:10, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2022-03-14 14:47:09 +0100, Daniel Gustafsson wrote:
>>> On 14 Mar 2022, at 01:08, Andres Freund <andres(at)anarazel(dot)de> wrote:
>>
>>> I was thinking that the way to use it would be to specify it as a client
>>> option. Like PGOPTIONS='-c ignore_event_trigger=login' psql.
>>
>> Attached is a quick PoC/sketch of such a patch, where 0001 adds a guc, 0002 is
>> the previously posted v25 login event trigger patch, and 0003 adapts is to
>> allow ignoring it (0002/0003 split only for illustrative purposes of course).
>> Is this along the lines of what you were thinking?
>
> Yes.
>
> Of course there's still the bogus cache invalidation stuff etc that I
> commented on upthread.
Yeah, that was the previously posted v25 from the author (who adopted it from
the original author). I took the liberty to quickly poke at the review
comments you had left as well as the ones that I had found to try and progress
the patch. 0001 should really go in it's own thread though to not hide it from
anyone interested who isn't looking at this thread.
--
Daniel Gustafsson https://vmware.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v27-0002-Add-a-new-login-event-and-login-event-trigger-su.patch | application/octet-stream | 24.9 KB |
| v27-0001-Provide-a-GUC-for-temporarily-ignoring-event-tri.patch | application/octet-stream | 7.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2022-03-15 20:59:08 | Re: Granting SET and ALTER SYSTE privileges for GUCs |
| Previous Message | Greg Stark | 2022-03-15 20:29:33 | Re: [PATCH] pgbench: add multiconnect option |