| From: | "Bagga, Rishu" <bagrishu(at)amazon(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | "Debnath, Shawn" <sdn(at)amazon(dot)com> |
| Subject: | Re: SLRUs in the main buffer pool - Page Header definitions |
| Date: | 2022-12-15 23:16:45 |
| Message-ID: | D663D8DD-6B13-4DF4-9A8D-045D5F0F2A7E@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Rebased and updated a new patch addressing the critical section issue in
RecordNewMultliXact.In GetNewMultiXactId, we now make our ReadBuffer
calls before starting the critical section, but while holding the
MultiXactGenLock, so we always fetch the correct buffers. We store them
in an array that is accessed later in RecordNewMultiXact.
This way we can keep the existing functionality of only holding the MultiXactGenLock while reading in buffers, but can let go when we are writing,
to preserve the existing concurrency paradigm.
Let me know your thoughts on this approach.
Sincerely,
Rishu Bagga, Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| slru_to_buffer_cache_with_page_headers_v3.patch | application/octet-stream | 348.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2022-12-15 23:17:46 | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
| Previous Message | Nathan Bossart | 2022-12-15 22:47:21 | Re: wake up logical workers after ALTER SUBSCRIPTION |