Re: fixes for a few GUC descriptions

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: fixes for a few GUC descriptions
Date: 2026-09-12 03:14:08
Message-ID: D5A16905-E7FE-47BF-BD37-5D97EC04A0A0@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Sep 11, 2026, at 23:34, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Fri, Sep 11, 2026 at 11:14:03AM +0200, Álvaro Herrera wrote:
>> Maybe it should say "0 means do not wait, -1 means wait indefinitely."
>> This complements the short_desc,
>>
>> Sets the maximum time the server waits during shutdown for all WAL data
>> to be replicated to the receiver.
>>
>> I think the words "for the receiver to catch up" is somehow at odds with
>> the short_desc's "for all WAL data to be replicated". They should be
>> saying the same thing, but aren't.
>
> WFM. v2 uses that wording, except -1 is listed first so that the special
> values stay in ascending order.
>
> I was considering back-patching this to v19. I'd rather not update the
> descriptions in released versions, although I'm not even sure anything in
> released versions need fixing. Any concerns about this?
>
> --
> nathan
> <v2-0001-Describe-special-values-in-more-GUC-descriptions.patch>

V2 LGTM.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-09-12 03:17:32 Re: REPACK (CONCURRENTLY) decoding worker is canceled by lock_timeout
Previous Message sahil verma 2026-09-12 03:12:12 Re: Speed up COPY TO text/CSV parsing using SIMD