| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Maksim(dot)Melnikov" <m(dot)melnikov(at)postgrespro(dot)ru> |
| Subject: | Re: Persist injection points across server restarts |
| Date: | 2025-05-21 09:17:55 |
| Message-ID: | D48BAF0D-71AD-44F1-9859-FBED8C38FDAB@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 21 May 2025, at 11:20, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Rebased, to fix a conflict I've introduced with a different commit.
I've looked into the patch set and have some more questions:
1. What if we flush many times? Is it supposed to overwrite injection_points.data?
2. What if we restart many times? first startup will remove the file... maybe remove it explicitly?
3. InjectionPoint private data is not handled, is it OK?
4. How session-local points are expected to be flushed? into which session they will be loaded? Maybe let's document that they are not saved?
Besides these, cool new abilities and a test for a bug, looks good to me.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2025-05-21 10:22:03 | Re: generic plans and "initial" pruning |
| Previous Message | Andrey Borodin | 2025-05-21 08:35:59 | Re: Allow reading LSN written by walreciever, but not flushed yet |