Re: pg_basebackup: Missing newlines in some error messages

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Banck <michael(dot)banck(at)credativ(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pg_basebackup: Missing newlines in some error messages
Date: 2018-03-21 12:24:22
Message-ID: D4773E9C-2E3C-4D61-ACDC-6C7BF14B0E40@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 21 Mar 2018, at 13:12, Michael Banck <michael(dot)banck(at)credativ(dot)de> wrote:

> while working on something else, I noticed that some error messages in
> pg_basebackup do not have a "\n" at the end, resulting in output like:
>
> |pg_basebackup: could not get COPY data stream: pg_basebackup: removing
> |data directory “data2"

There seems to be a few more in the other files, for example this (and more) in
receivelog.c:

- fprintf(stderr, _("%s: could not send feedback packet: %s"),
+ fprintf(stderr, _("%s: could not send feedback packet: %s\n"),

Should they get newlines appended as well?

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-03-21 12:25:11 Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug
Previous Message Pavan Deolasee 2018-03-21 12:23:47 Re: [HACKERS] MERGE SQL Statement for PG11