Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)
Date: 2022-09-05 08:24:25
Message-ID: D4651C34-3A32-4A74-BCEE-F78F30F17C6C@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Sep 2022, at 14:39, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:

> But with Windows 10 build, I got this diff result:
>
> diff -w -U3 C:/dll/postgres_dev/postgres_master/src/test/regress/expected/geometry.out C:/dll/postgres_dev/postgres_master/src/test/regress/results/geometry.out
> --- C:/dll/postgres_dev/postgres_master/src/test/regress/expected/geometry.out 2022-09-01 08:05:03.685931000 -0300
> +++ C:/dll/postgres_dev/postgres_master/src/test/regress/results/geometry.out 2022-09-04 09:27:47.133617800 -0300
> @@ -4380,9 +4380,8 @@
> <(100,200),10> | <(100,200),10>
> <(100,1),115> | <(100,1),115>
> <(3,5),0> | <(3,5),0>
> - <(3,5),NaN> | <(3,5),0>
> <(3,5),NaN> | <(3,5),NaN>
> -(9 rows)
> +(8 rows)
>
> -- Overlap with circle
> SELECT c1.f1, c2.f1 FROM CIRCLE_TBL c1, CIRCLE_TBL c2 WHERE c1.f1 && c2.f1;
>
> Not sure why.

That's not just on Windows, and it makes total sense as a radius of NaN isn't
the same as a radius of zero.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-09-05 08:32:20 Re: Patch to address creation of PgStat* contexts with null parent context
Previous Message Kyotaro Horiguchi 2022-09-05 08:12:10 Re: [BUG] Storage declaration in ECPG