Re: vacuumdb: add --dry-run

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: vacuumdb: add --dry-run
Date: 2025-12-08 23:04:24
Message-ID: D34BB1FD-C704-4855-804D-932C054B1981@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Dec 9, 2025, at 03:24, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Mon, Dec 08, 2025 at 12:27:26PM -0600, Nathan Bossart wrote:
>> On Mon, Dec 08, 2025 at 07:23:16PM +0100, Álvaro Herrera wrote:
>>> I haven't read this thread, but chanced to come across this and wanted
>>> to note recent commit c05dee191125. I'm not opposed to changing what
>>> went in there, but let's make them all the same.
>>
>> Ah, that must've been where I stole from originally. Will switch it back.
>
> As promised...
>
> --
> nathan
> <v7-0001-vacuumdb-Move-some-options-to-vacuumingOptions-st.patch><v7-0002-Add-ParallelSlotSetIdle.patch><v7-0003-vacuumdb-Add-dry-run.patch>

I searched over the source tree, and find “Running in xxx mode” in initdb and option.c:

Initdb:
```
printf(_("Running in debug mode.\n"));

printf(_("Running in no-clean mode. Mistakes will not be cleaned up.\n"));```

Options.
```
pg_log(PG_REPORT, "Running in verbose mode”);
```

And “”Executing in dry-run mode” in a few commands: pg_archivecleanup.c, pg_createsubscriber.c, pg_combinebackup.c and pg_rewind.c.

Should we make them all consistent?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-12-08 23:11:46 Re: Introduce Index Aggregate - new GROUP BY strategy
Previous Message Nathan Bossart 2025-12-08 22:39:25 Re: [PATCH] Fix inconsistent title attribute tags in documentation