Re: [sqlsmith] Planner crash on foreign table join

From: Mark Dilger <hornschnorter(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: [sqlsmith] Planner crash on foreign table join
Date: 2017-04-09 02:51:29
Message-ID: D323FE6C-13D7-47B0-8453-D3DB011D72D8@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On Apr 8, 2017, at 7:41 PM, Mark Dilger <hornschnorter(at)gmail(dot)com> wrote:
>
>
>> On Apr 8, 2017, at 7:35 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
>>> This is very near where the original crash reported in this thread was crashing, probably only
>>> different due to the extra lines of Assert that were added. Am I missing some portion of the
>>> fix that you are testing? I have only applied the patch that Tom included in the previous email.
>>
>> No, that was the whole patch --- but did you do a full "make clean" and
>> rebuild? The patch changed NodeTag numbers which would affect the whole
>> tree.
>
> <snip>

> I'm going to pull completely fresh sources and reapply and retest, though you are welcome
> to review my patch while I do that.

That fixed it. Thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2017-04-09 08:53:34 Re: Performance improvement for joins where outer side is unique
Previous Message Mark Dilger 2017-04-09 02:41:36 Re: [sqlsmith] Planner crash on foreign table join