Re: Inefficient handling of LO-restore + Patch

From: "Mario Weilguni" <mario(dot)weilguni(at)icomedias(dot)com>
To: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inefficient handling of LO-restore + Patch
Date: 2002-04-24 14:28:05
Message-ID: D143FBF049570C4BB99D962DC25FC2D2178139@freedom.icomedias.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wanted to correct the patch this evening after work, and will check your changes. Thanks!

-----Ursprüngliche Nachricht-----
Von: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
Gesendet: Mittwoch, 24. April 2002 16:03
An: Peter Eisentraut
Cc: Mario Weilguni; pgsql-hackers(at)postgresql(dot)org
Betreff: Re: [HACKERS] Inefficient handling of LO-restore + Patch

OK, I have applied the following patch to fix these warnings. However,
I need Mario to confirm these are the right changes. Thanks.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> This patch does not compile correctly:
>
> pg_backup_archiver.c: In function `ahwrite':
> pg_backup_archiver.c:1252: warning: pointer of type `void *' used in arithmetic
> pg_backup_archiver.c:1259: warning: pointer of type `void *' used in arithmetic
> pg_backup_archiver.c:1263: warning: pointer of type `void *' used in arithmetic
> make: *** [pg_backup_archiver.o] Error 1
>
>
> Bruce Momjian writes:
>
> >
> > Patch applied. Thanks.
> >
> > ---------------------------------------------------------------------------
> >
> >
> > Mario Weilguni wrote:
> > > Am Donnerstag, 11. April 2002 17:44 schrieb Tom Lane:
> > > > "Mario Weilguni" <mario(dot)weilguni(at)icomedias(dot)com> writes:
> > > > > And I did not find out how I can detect the large object
> > > > > chunksize, either from getting it from the headers (include
> > > > > "storage/large_object.h" did not work)
> > > >
> > >
> > > You did not answer if it's ok to post the patch, hope it's ok:
> >
> >
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-04-24 14:30:26 Re: Inefficient handling of LO-restore + Patch
Previous Message Thomas Lockhart 2002-04-24 14:23:27 Re: Vote on SET in aborted transaction