Re: [Proposal] Allow users to specify multiple tables in VACUUM commands

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Proposal] Allow users to specify multiple tables in VACUUM commands
Date: 2017-05-19 03:17:54
Message-ID: D1074511-B13A-42EB-A650-24CE5B33260E@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/18/17, 8:03 PM, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>”Bossart, Nathan" <bossartn(at)amazon(dot)com> writes:
>> On 5/18/17, 6:12 PM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> Fine for me as well. I would suggest to split the patch into two parts
>>> to ease review then:
>>> - Rework this error handling for one relation.
>>> - The main patch.
>>
>> I’d be happy to do so, but I think part one would be pretty small, and almost all of the same code needs to be changed in the main patch anyway. I do not foresee a huge impact on review-ability either way. If others disagree, I can split it up.
>
>Yeah, I'm dubious that that's really necessary. If the change proves
>bigger than you're anticipating, maybe it's worth a two-step approach,
>but I share your feeling that it probably isn’t.

Just in case it was missed among the discussion, I’d like to point out that v5 of the patch includes the “ERROR if ANALYZE not specified” change.

Nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2017-05-19 03:23:20 Re: Documentation about pg_stat_bgwriter
Previous Message Tom Lane 2017-05-19 03:03:51 Re: [Proposal] Allow users to specify multiple tables in VACUUM commands