Re: New year, new commitfest app improvements

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: New year, new commitfest app improvements
Date: 2026-01-14 02:39:51
Message-ID: D0E496EF-F191-46AC-BDB5-C4D1CC3A72EE@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jan 7, 2026, at 02:46, Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:
>
> Hi all,
>
> There are some big changes lined up for the next release of the
> commitfest app. I'm intending to deploy these to prod in on the 20th
> of January.
> 1. Remove the "topics" feature and replace it fully with the tags
> feature. For patches in most topics a matching tag will be added
> automatically (e.g. "Bug fixes" topic -> "Bugfix" tag). But there are
> a few where the conversion is lossy:
> # 'Miscellaneous' and 'Server Features' are left untagged, because they
> # are too vague.
> # 'Procedural Languages' has no direct tag equivalent, because new
> # there are tags per language. So there's no clear tag that should be
> # chosen there. Similar for 'Replication & Recovery', which also has
> # separate tags now for logical and physical replication.
>
> Full details on how stuff gets replaced can be found here[1]
> 2. Commitfests now get closed in a more "friendly" manner for patch
> authors. Before authors would need to move their patches to the next
> commitfests manually. Now this is done automatically if a patch has
> had an email on the thread within 30 days AND it has had a green CI
> run in the last 21 days.
> 3. For patches that did not get moved automatically by the new logic
> described above, authors will get an email that they should move or
> close these patches. (they only get this email if they have subscribed
> to author email notifications, see 5)
> 4. Old commitfests and patches that are open on old commitfests now
> contain a banner warning (see attached).
> 5. Change the default email notification settings to receive
> commitfest app emails for patches where you are an author. This only
> applies to new users and users who have never visited their profile
> page. Emails now include a link to the profile, so you can unsubscribe
> or subscribe to more emails.
> 6. The Draft CF page won't show "Moved to other CF" entries anymore.
> (Thanks Aditya)
> 7. Fix bug where not all emails would be noticed by the app (already
> deployed to prod)
>
> As always, feedback is welcome. You can see the changes live here:
> https://commitfest-test.postgresql.org/ (username and password are "pgtest")
>
> [1]: https://github.com/postgres/pgcommitfest/blob/fbd6aa760d8cc694e0a7e879ce793f51eb421915/pgcommitfest/commitfest/migrations/0016_migrate_topics_to_tags.py#L33-L51
> <image.png>

Hi Jelte,

Thanks for the wonderful upgrade. I have a small suggestion.

Suppose a patch has already created a CF entry, and a reviewer wants to suggest a code change and attaches a diff file in the thread. In that case, CI will automatically pick up the diff and run tests, which will very likely result in a CI failure. I’ve run into this situation myself; see [1].

Would it make sense for CI to only pick up .patch files and ignore .diff files? Or provide some way else to indicate CI to ignore certain emails?

[1] https://postgr.es/m/CANWCAZZo5rgE4+NYYES1hLN9PvonXMH=K3Z7b0TKcCBNOAjaag@mail.gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-01-14 02:44:57 Re: Optimize LISTEN/NOTIFY
Previous Message Andreas Karlsson 2026-01-14 02:38:10 Re: Add IS_INDEX macro to brin and gist index