RE: pg_upgrade: Pass -j down to vacuumdb

From: "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>
To: "'jesper(dot)pedersen(at)redhat(dot)com'" <jesper(dot)pedersen(at)redhat(dot)com>, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "fabriziomello(at)gmail(dot)com" <fabriziomello(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: RE: pg_upgrade: Pass -j down to vacuumdb
Date: 2019-03-12 01:37:37
Message-ID: D09B13F772D2274BB348A310EE3027C64659E9@g01jpexmbkw24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Jesper,

Sorry I almost completely forgot to get back to you on this.
Actually your patch works when I tested it before,
and I understand the intention.
Although a point was raised by other developers by making
--jobs optional in the suggested line by using the env variable instead.

> > Kirk, can you provide a delta patch to match what you are thinking ?

I was thinking of something like the attached,
but the user needs to edit the variable value though.
I am not sure how to implement the suggestion to allow the
script to absorb a value from the environment,
so that it doesn't need to be edited at all.

Kirk Jamison

Attachment Content-Type Size
v8_0001-Use-vacuumdb-opt-env-variable-to-pass-vacuumdb-options.patch application/octet-stream 2.8 KB application/octet-stream 903 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Nagaura, Ryohei 2019-03-12 01:39:08 RE: Timeout parameters
Previous Message Zhang, Jie 2019-03-12 01:37:04 [PATCH] remove repetitive characters in fdwhandler.sgml