| From: | "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | "'jesper(dot)pedersen(at)redhat(dot)com'" <jesper(dot)pedersen(at)redhat(dot)com>, "Peter Eisentraut" <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | "fabriziomello(at)gmail(dot)com" <fabriziomello(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | RE: pg_upgrade: Pass -j down to vacuumdb |
| Date: | 2019-01-29 00:35:30 |
| Message-ID: | D09B13F772D2274BB348A310EE3027C64146AF@g01jpexmbkw24 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Jesper,
Thanks for updating your patches quickly.
>On 1/28/19 3:50 PM, Peter Eisentraut wrote:
>>> Done, and v4 attached.
>>
>> I would drop the changes in pgupgrade.sgml. We don't need to explain
>> what doesn't happen, when nobody before now ever thought that it would
>> happen.
>>
>> Also, we don't need the versioning stuff. The new cluster in
>> pg_upgrade is always of the current version, and we know what that one supports.
>>
>Done.
I just checked the patch.
As per advice, you removed the versioning and specified --jobs.
The patch still applies, builds and passed the tests successfully.
I'd argue though that it's helpful to find a short documentation to clarify
that it's not pass down by to vacuumdb default. I think the initial doc
change from the previous patch would be good.
+ machine. Note, that this option isn't passed to the
+ <application>vacuumdb</application> application by default.
Just remove the comma symbol from "Note, that..."
Regards,
Kirk Jamison
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-01-29 00:40:36 | Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()? |
| Previous Message | Amit Kapila | 2019-01-29 00:29:02 | Re: WIP: Avoid creation of the free space map for small tables |