Re: pgsql: Unbreak the build.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org, Robert Haas <rhaas(at)postgresql(dot)org>
Subject: Re: pgsql: Unbreak the build.
Date: 2022-03-23 14:58:18
Message-ID: D0868780-E8A6-4CD9-A00C-60FB520094A3@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On March 23, 2022 7:46:10 AM PDT, Andres Freund <andres(at)anarazel(dot)de> wrote:
>Hi,
>
>On March 23, 2022 7:24:13 AM PDT, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>>Unbreak the build.
>>
>>Commit ffd53659c46a54a6978bcb8c4424c1e157a2c0f1 broke the build for
>>anyone not compiling with LZ4 and ZSTD enabled. Woops.
>
>There's new warnings that sound reasonable introduced in the prior commit that didn't get removed in this one:
>
>https://cirrus-ci.com/task/5259487073271808?logs=mingw_cross_warning#L392

And windows still fails tests after this commit: https://cirrus-ci.com/task/6424123323711488?logs=test_bin#L22

Andres

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2022-03-23 15:19:07 pgsql: Force NO_LOCALE / UTF8 for test_oat_hooks tests
Previous Message Andres Freund 2022-03-23 14:46:10 Re: pgsql: Unbreak the build.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-03-23 15:14:23 Re: Use JOIN USING aliases in ruleutils.c
Previous Message Simon Riggs 2022-03-23 14:53:04 Re: Parameter for planner estimate of recursive queries