Re: Where can I find the doxyfile?

From: John Morris <john(dot)morris(at)crunchydata(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Bohdan Mart <mart(dot)bogdan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, "postgres(at)coyotebush(dot)net" <postgres(at)coyotebush(dot)net>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Subject: Re: Where can I find the doxyfile?
Date: 2024-02-13 01:34:19
Message-ID: CYXP222MB09470E64A6D7755B42EA65B1A04F2@CYXP222MB0947.NAMP222.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Update: another patch with 1) suggested changes, 2) delete old html before generating new, and 3) added flex names for the more complex regular expressions.

Exercising the “ninja doxygen” command, brought up some issues.

1. The generated html directory contained old as well as new pages.
The build script now deletes old pages before building new ones.
2. Using a line of dashes to suppress text formatting is not implemented.
Some dashed comments are harder to read, especially around code samples.
3. Comments at the end of “#define” are considered part of the define
and not annotated as doxygen comments.

The first issue was very confusing, so it has been fixed.
My preference is to make the other two issues part of a future enhancement. Thoughts?

I’ve also been scanning the generated pages looking for anomalies.

1. About 1/3 of pages examined.
2. In most cases, the filter works as expected.
3. Many places are missing information, so the output has blank fields (as expected).
4. A few places have obvious nonsense. (eg. a group comment applied to one element)
5. No situations where the output would be misleading.
6. In all cases, the source code is “a click away”.

While I had planned to look at *every* page, I’ll probably stop at the 1/3 sample – unless someone wants to help scan through the pages with me.

I also heard back from Jetbrains about incorporating custom Doxyfiles. They do their own rendering and do not invoke the doxygen command. Custom Doxyfiles are not going to happen. (It’s probably the same for VS.)

On my Mac M1, generating doxygen takes about 20 seconds. When graphs are added, it takes 5 minutes.

Attachment Content-Type Size
doxygen_v5.patch application/octet-stream 16.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2024-02-13 01:44:33 Re: LogwrtResult contended spinlock
Previous Message Jeff Davis 2024-02-13 01:33:24 Re: Improve WALRead() to suck data directly from WAL buffers when possible