| From: | Miłosz Bieniek <milosz(at)bieniek(dot)cc> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Refactor parse_publication_options |
| Date: | 2026-08-23 16:43:00 |
| Message-ID: | CVqp0ITYe3mo8Sp9p-lY8hjcuj1SxmM9kkLeeOoi3wgtvPbOkpqSxQ4rV7tgvEG9n4-TNlMOohV2U61e-6J8MoKPly5_NkpZ5JVSvJi_0d4=@bieniek.cc |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While reading the code related to creating subscriptions and publications for logical replication I found a difference between passing options to parse_subscription_options and parse_publication_options.
To parse_publication_options function we pass all options separately, while in parse_subscription_options we use SubOpts.
IMO the usage of a struct instead of each option separately seems cleaner.
I attached a patch that creates a PubOpts struct and uses it in all parse_publication_options occurrences.
--
Miłosz Bieniek
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Refactor-parse_publication_options.patch | application/octet-stream | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-08-23 16:55:32 | Re: Allow a prosupport function to be attached to an aggregate |
| Previous Message | Andrey Borodin | 2026-08-23 16:28:47 | Re: [PATCH] Fix vacuum_delay_point happening inside lock |