Re: pg_upgrade --check fails to warn about abstime

From: "Tristan Partin" <tristan(at)neon(dot)tech>
To: "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "Pg Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_upgrade --check fails to warn about abstime
Date: 2023-09-20 17:45:36
Message-ID: CVNXKGJRAAWS.25S80HUEMM7II@neon.tech
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> +/*
> + * check_for_removed_data_type_usage
> + *
> + * similar to the above, but for types that were removed in 12.
> + */
> +static void
> +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *datatype)

Seems like you could make this more generic instead of hardcoding
version 12, and then you could use it for any future removed types as
well.

Just a thought.

--
Tristan Partin
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-09-20 17:58:07 Re: pg_upgrade --check fails to warn about abstime
Previous Message Alvaro Herrera 2023-09-20 16:54:24 pg_upgrade --check fails to warn about abstime