RE: [Proposal] Level4 Warnings show many shadow vars

De: Michael Paquier
Enviadas: Terça-feira, 17 de Dezembro de 2019 00:36

>Hmm. In the case of this logic, we are referring to the current end
>of WAL with endptr, and what you are calling the startptr is really
>the redo LSN of the last checkpoint in all the routines which are now
>confused with RedoRecPtr: RemoveOldXlogFile, RemoveXlogFile and
>XLOGfileslop. Using lower-case for all the characters of the variable
>name sounds like a good improvement as well, so taking a combination
>of all that I would just use "lastredoptr" in those three code paths
>(note that we used to have PriorRedoPtr before). As that's a
>confusion I introduced with d9fadbf, I would like to fix that and
>backpatch this change down to 11. (Ranier gets the authorship
>per se as that's extracted from a larger patch).
Hey Michael, thank you so much for considering correct at least part of an extensive work.

Best regards,
Ranier Vilela