| From: | Ranier Vilela <ranier_gyn(at)hotmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [Proposal] Level4 Warnings show many shadow vars |
| Date: | 2019-12-18 10:16:49 |
| Message-ID: | CO2PR05MB26297D66D21CA1FB0424B7DBE3530@CO2PR05MB2629.namprd05.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
De: Michael Paquier
Enviadas: Quarta-feira, 18 de Dezembro de 2019 01:18
>Committed that part.
Thanks.
>Let's take one example. The changes in pg_dump/ like
>/progname/prog_name/ have just been done in haste, without actual
>thoughts about how the problem ought to be fixed. And in this case,
>something which could be more adapted is to remove the argument from
>usage() because progname is a global variable, initialized from the
>beginning in pg_restore.
Yeah, this is good hint about how improve the patch.
Best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2019-12-18 10:28:21 | RE: [PATCH] Windows port add support to BCryptGenRandom |
| Previous Message | Ranier Vilela | 2019-12-18 10:13:03 | RE: [PATCH] Fix possible underflow in expression (maxoff - 1) |