| From: | "Dian M Fay" <dian(dot)m(dot)fay(at)gmail(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "David Steele" <david(at)pgmasters(dot)net>, "Georgios Kokolatos" <gkokolatos(at)protonmail(dot)com>, "PostgreSQL Developers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] postgres_fdw: suppress explicit casts in text:text comparisons (was: column option to override foreign types) |
| Date: | 2021-11-12 01:07:14 |
| Message-ID: | CFNED8NO750S.3I7DYZT2ZGMX7@lamia |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu Nov 11, 2021 at 3:36 PM EST, Tom Lane wrote:
> I thought about this some more and realized exactly why I wanted to
> restrict the change to cases where the other side is a plain foreign
> Var: that way, if anything surprising happens, we can blame it
> directly on the user having declared a local column with a different
> type from the remote column.
>
> That being the case, I took a closer look at deparseVar and realized
> that we can't simply check "IsA(node, Var)": some Vars in the
> expression can belong to local tables. We need to verify that the Var
> is one that will print as a remote column reference.
Eminently reasonable all around! `git apply` insisted that the v8 patch
didn't (apply, that is), but `patch -p1` liked it fine. I've put it
through a few paces and it seems good; what needs to happen next?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2021-11-12 01:22:34 | Re: XLogReadRecord() error in XlogReadTwoPhaseData() |
| Previous Message | Bruce Momjian | 2021-11-12 01:04:29 | Re: storing an explicit nonce |