Re: Git revision in tarballs

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Git revision in tarballs
Date: 2021-07-21 19:12:07
Message-ID: CFE5FEBB-C0C3-49F7-BBF2-A01EB5292EB2@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 21 Jul 2021, at 20:25, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 15.07.21 10:33, Magnus Hagander wrote:
>> I think it'd be useful to be able to identify exactly which git commit
>> was used to produce a tarball. This would be especially useful when
>> downloading snapshot tarballs where that's not entirely clear, but can
>> also be used to verify that the release tarballs matches what's
>> expected (in the extremely rare case that a tarball is rewrapped for
>> example).
>
> Or we could do what git-archive does:
>
> Additionally the commit ID is stored in a global extended
> pax header if the tar format is used; it can be extracted using git
> get-tar-commit-id. In ZIP files it is stored as
> a file comment.

That does adds Git as a dependency for consuming the tarball though, which
might not be a problem but it's a change from what we require today.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-07-21 19:23:41 Re: Git revision in tarballs
Previous Message Peter Eisentraut 2021-07-21 18:25:14 Re: Git revision in tarballs