Re: Estimating HugePages Requirements?

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pryzby(at)telsasoft(dot)com" <pryzby(at)telsasoft(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "magnus(at)hagander(dot)net" <magnus(at)hagander(dot)net>, "mark(dot)dilger(at)enterprisedb(dot)com" <mark(dot)dilger(at)enterprisedb(dot)com>, "don(at)seiler(dot)us" <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Estimating HugePages Requirements?
Date: 2021-09-15 22:31:20
Message-ID: CFC83662-D204-4624-A155-2FCEE4C65D39@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin pgsql-hackers

On 9/14/21, 8:06 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> Attached is a refreshed patch (commit message is the same as v9 for
> now), with some minor tweaks and the tests.
>
> Thoughts?

LGTM

+ This can be used on a running server for most parameters. However,
+ the server must be shut down for some runtime-computed parameters
+ (e.g., <xref linkend="guc-shared-memory-size"/>, and
+ <xref linkend="guc-wal-segment-size"/>).

nitpick: I think you can remove the comma before the "and" in the list
of examples.

Nathan

In response to

Responses

Browse pgsql-admin by date

  From Date Subject
Next Message Michael Paquier 2021-09-16 02:41:55 Re: Estimating HugePages Requirements?
Previous Message Michael Paquier 2021-09-15 03:05:21 Re: Estimating HugePages Requirements?

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2021-09-15 22:49:39 Re: Deduplicate code updating ControleFile's DBState.
Previous Message Peter Geoghegan 2021-09-15 22:08:41 Re: decoupling table and index vacuum