| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Should vacuum process config file reload more often |
| Date: | 2023-04-15 20:40:08 |
| Message-ID: | CEA90315-587C-4CAB-97A9-B5BE8ECE09A0@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 11 Apr 2023, at 17:05, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> The comment of message_level_is_interesting() says:
>
> * This is useful to short-circuit any expensive preparatory work that
> * might be needed for a logging message.
>
> Which can apply to taking a lwlock, I think.
I agree that we can, and should, use message_level_is_interesting to skip
taking this lock. Also, the more I think about the more I'm convinced that we
should not change the current logging frequency of once per table from what we
ship today. In DEGUG2 the logs should tell the whole story without requiring
extrapolation based on missing entries. So I think we should use your patch to
solve this open item. If there is interest in reducing the logging frequency
we should discuss that in its own thread, insted of it being hidden in here.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shaurya jain | 2023-04-15 21:10:57 | Logical replication failed with SSL SYSCALL error |
| Previous Message | Tom Lane | 2023-04-15 19:47:49 | Race conditions in has_table_privilege() and friends |