Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?

> On 8 Jul 2019, at 00:02, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Wed, Jun 12, 2019 at 1:21 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> The patch is still rough around the edges (TODO’s left to mark some areas), but
>> I prefer to get some feedback early rather than working too far in potentially
>> the wrong direction, so parking this in the CF for now.
>
> Hi Daniel,
>
> Given the above disclaimers the following may be entirely expected,
> but just in case you weren't aware:
> t/010_logical_decoding_timelines.pl fails with this patch applied.
>
> https://travis-ci.org/postgresql-cfbot/postgresql/builds/555205042

I hadn’t seen since I had fat-fingered and accidentally run the full tests in a
tree without assertions. The culprit here seems to an assertion in the logical
decoding code which doesn’t account for heap_multi_insert into catalog
relations (which there are none now, this patch introduce them and thus trip
the assertion). As the issue is somewhat unrelated, I’ve opened a separate
thread with a small patch:

https://postgr.es/m/CBFFD532-C033-49EB-9A5A-F67EAEE9EB0B@yesql.se

The attached v3 also has that fix in order to see if the cfbot is happier with
this.

cheers ./daniel